Re: [PATCH net-next 2/2] bnx2x: Coalesce pr_cont uses and fix DP typos
flat view
From: Eilon Greenstein <hidden>
Date: 2011-08-09 14:41:39
Also in:
lkml
On Mon, 2011-08-08 at 08:53 -0700, Joe Perches wrote:
Uses of pr_cont should be avoided where reasonably possible because they can be interleaved by other threads and processes. Coalesce pr_cont uses. Fix typos, duplicated words and spacing in DP uses caused by split multi-line formats. Coalesce some of these split formats. Add missing terminating newlines to DP uses. Signed-off-by: Joe Perches <joe@perches.com> ---
....
quoted hunk ↗ jump to hunk
@@ -12254,7 +12261,7 @@ void bnx2x_period_func(struct link_params *params, struct link_vars *vars) { struct bnx2x *bp = params->bp; if (!params) { - DP(NETIF_MSG_LINK, "Ininitliazed params !\n"); + DP(NETIF_MSG_LINK, "Uninitialized params !\n"); return; } /* DP(NETIF_MSG_LINK, "Periodic called vars->phy_flags 0x%x speed 0x%x
This does not apply on the current net-next. Other than that - it looks good. Please re-submit this patch series once net-next is opened for driver changes (see: http://marc.info/?l=linux-netdev&m=131278578427946&w=2 ) and I will ACK it. Thanks, Eilon