Thread (3 messages) 3 messages, 3 authors, 2011-08-26

RE: [patch -next] bna: unlock on error path in pnad_pci_probe()

From: Rasesh Mody <hidden>
Date: 2011-08-24 17:25:52
Also in: kernel-janitors

quoted hunk ↗ jump to hunk
From: Dan Carpenter [mailto:error27@gmail.com]
Sent: Wednesday, August 24, 2011 4:29 AM

We introduced a new lock here, so there was error path which needs
an unlock now.

Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/net/ethernet/brocade/bna/bnad.c
b/drivers/net/ethernet/brocade/bna/bnad.c
index bdfda07..6ad4b47 100644
--- a/drivers/net/ethernet/brocade/bna/bnad.c
+++ b/drivers/net/ethernet/brocade/bna/bnad.c
@@ -3167,7 +3167,7 @@ bnad_pci_probe(struct pci_dev *pdev,
	 */
	err = bnad_pci_init(bnad, pdev, &using_dac);
	if (err)
-		goto free_netdev;
+		goto unlock_mutex;

	/*
	 * Initialize bnad structure
@@ -3296,9 +3296,9 @@ drv_uninit:
	bnad_uninit(bnad);
pci_uninit:
	bnad_pci_uninit(pdev);
+unlock_mutex:
	mutex_unlock(&bnad->conf_mutex);
	bnad_lock_uninit(bnad);
-free_netdev:
	free_netdev(netdev);
	return err;
}
Acked-by: Rasesh Mody <redacted>

Thanks,
Rasesh
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help