RE: [net-next 04/12] bna: TX Path and RX Path Changes

From: David Miller [mailto:davem@davemloft.net]
Sent: Monday, August 22, 2011 4:46 PM

From: Rasesh Mody <redacted>
Date: Mon, 22 Aug 2011 15:41:01 -0700

quoted

+		if (unlikely(skb_is_gso(skb) > netdev->mtu)) {

skb_is_gso() is mean to be a boolean test, it happens to return
the value of ->gso_size as it's implementation but that's not
a good reason for you to abuse this interface in this way.

If we every fix skb_is_gso() to return a true 'bool' your driver
will break.

Access ->gso_size directly if that's what you're interested in,
that way it's future proof and won't break in the future.

Hi Dave,
We've addressed this by accessing ->gso_size directly and resubmitted
the patch-set.
Thanks for the suggestion,
--Rasesh