Thread (15 messages) 15 messages, 2 authors, 2011-08-20

Re: [PATCH 04/13] bna: SKB Check and Drop Macros

flat view

From: David Miller <davem@davemloft.net>
Date: 2011-08-20 18:06:09

From: Rasesh Mody <redacted>
Date: Fri, 19 Aug 2011 14:39:23 -0700
Add macros to check and drop skb from transmit path and return.

Signed-off-by: Gurunatha Karaje <redacted>
Signed-off-by: Rasesh Mody <redacted>
Do not EVER create macros that have the side effect of doing
a function return.

This makes code impossible to read and audit, because it is not
possible to see just by looking at the macro invocation that the
function might be returned from what at that moment.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help