RE: [PATCH 06/14] bna: TX Path and RX Path Changes

From: Ben Hutchings [mailto:bhutchings@solarflare.com]
Sent: Tuesday, August 16, 2011 2:46 PM

On Tue, 2011-08-16 at 14:19 -0700, Rasesh Mody wrote:

quoted

Change details:
 - Disable and enable interrupts from the same polling context to

prevent

quoted

   reordering in Rx path.
 - Add Rx NAPI debug counters.
 - Make NAPI budget check more generic
 - Add a macro bnad_dim_timer_stop for DIM(Dynamic Interrupt

Moderation)

quoted

   timer stop
 - Handle reduced MSI-X vectors case in bnad_enable_msix
 - Replace existing checks with macros and add more checks for illegal

skbs

quoted

   in transmit path. Add more tx_skb counters for dropped skbs.
 - Check for single frame TSO skbs and send them out as non-TSO.
 - Put memory barrier after bna_txq_prod_indx_doorbell()

Signed-off-by: Gurunatha Karaje <redacted>
Signed-off-by: Rasesh Mody <redacted>
---
 drivers/net/ethernet/brocade/bna/bnad.c |  207 +++++++++++++++++-----

---------

quoted

 drivers/net/ethernet/brocade/bna/bnad.h |   33 +++++-
 2 files changed, 148 insertions(+), 92 deletions(-)

diff --git a/drivers/net/ethernet/brocade/bna/bnad.c

b/drivers/net/ethernet/brocade/bna/bnad.c

quoted

index 64e2106..0faa8a1 100644

--- a/drivers/net/ethernet/brocade/bna/bnad.c
+++ b/drivers/net/ethernet/brocade/bna/bnad.c

@@ -532,7 +532,7 @@ bnad_poll_cq(struct bnad *bnad, struct bna_ccb

*ccb, int budget)

quoted

 		      (flags & BNA_CQ_EF_L4_CKSUM_OK)))
 			skb->ip_summed = CHECKSUM_UNNECESSARY;
 		else
-			skb_checksum_none_assert(skb);
+			skb->ip_summed = CHECKSUM_NONE;

 		rcb->rxq->rx_packets++;
 		rcb->rxq->rx_bytes += skb->len;

[...]

This is reverting part of:

commit bc8acf2c8c3e43fcc192762a9f964b3e9a17748b
Author: Eric Dumazet [off-list ref]
Date:   Thu Sep 2 13:07:41 2010 -0700

   drivers/net: avoid some skb->ip_summed initializations

and I don't see any justification for that.

It is an erroneous change, this change will be dropped when resubmitting
this patch set.
Thanks,
Rasesh