Thread (5 messages) 5 messages, 3 authors, 2011-08-14

Re: [PATCH net] vmxnet3: Don't enable vlan filters in promiscuous mode.

flat view

From: Shreyas Bhatewara <hidden>
Date: 2011-08-10 03:00:51

Adds and removes are not ignored when in promiscuous mode because the
active_vlans bitfield is still being updated (this is in the context
that you clipped out).  When we come out of promiscuous mode,
vmxnet3_restore_vlan() is called which will update the hardware with
the vlans that have been registered.  This is much safer than directly
updating vfTable because it will get overwritten if vmxnet3_set_mc()
is called again and is potentially very error prone to have it not
reflect what we actually want programmed in the hardware.
Thats right.

Signed-off-by: Shreyas N Bhatewara <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help