Re: [PATCH] slip: fix NOHZ local_softirq_pending 08 warning
flat view
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: 2011-08-09 17:08:22
Hello Ilya, is the processing of characters in the tty input stream for line disciplines *always* done in softirq context??? If so, i would send a patch for drivers/net/can/slcan.c too ... Thanks, Oliver On 05.08.2011 21:23, Matvejchikov Ilya wrote:
quoted hunk ↗ jump to hunk
When using nanosleep() in an userspace application we get a ratelimit warning: NOHZ: local_softirq_pending 08 According to 481a8199142c050b72bff8a1956a49fd0a75bbe0 the problem is caused by netif_rx() function. This patch replaces netif_rx() with netif_rx_ni() which has to be used from process/softirq context. Signed-off-by: Matvejchikov Ilya <redacted> --- drivers/net/slip.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/net/slip.c b/drivers/net/slip.c index f11b3f3..4c61753 100644 --- a/drivers/net/slip.c +++ b/drivers/net/slip.c@@ -367,7 +367,7 @@ static void sl_bump(struct slip *sl) memcpy(skb_put(skb, count), sl->rbuff, count); skb_reset_mac_header(skb); skb->protocol = htons(ETH_P_IP); - netif_rx(skb); + netif_rx_ni(skb); dev->stats.rx_packets++; }