Thread (4 messages) 4 messages, 3 authors, 2011-08-12

Re: [PATCH net-next] neigh: reduce arp latency

flat view

From: Julian Anastasov <ja@ssi.bg>
Date: 2011-08-09 17:01:33

	Hello,

On Tue, 9 Aug 2011, Eric Dumazet wrote:
quoted hunk ↗ jump to hunk
Remove the artificial HZ latency on arp resolution.

Instead of firing a timer in one jiffy (up to 10 ms if HZ=100), lets
send the ARP message immediately.
@@ -957,7 +964,8 @@ int __neigh_event_send(struct neighbour *neigh, struct sk_buff *skb)
 			atomic_set(&neigh->probes, neigh->parms->ucast_probes);
 			neigh->nud_state     = NUD_INCOMPLETE;
 			neigh->updated = jiffies;
-			neigh_add_timer(neigh, now + 1);
+			neigh_add_timer(neigh, now + HZ);
	To be correct with old NUD_INCOMPLETE logic may be we can use 
max(neigh->parms->retrans_time, HZ/2) here instead of HZ?
quoted hunk ↗ jump to hunk
+			immediate_probe = true;
 		} else {
 			neigh->nud_state = NUD_FAILED;
 			neigh->updated = jiffies;
Regards

--
Julian Anastasov [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help