Re: [PATCH 3/4] powerpc/p1010: FlexCAN Controller for of_ type

On 08/09/2011 12:29 PM, U Bhaskar-B22300 wrote:

quoted

-----Original Message-----
From: Marc Kleine-Budde [mailto:mkl-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org]
Sent: Monday, August 08, 2011 8:51 PM
To: U Bhaskar-B22300
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; holt-sJ/iWh9BUns@public.gmane.org; wg-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org;
davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org; linuxppc-release-50dRxjG7WBCY5r8RbUyfqNHuzzzSOjJt@public.gmane.org; U Bhaskar-
B22300; socketcan-core-0fE9KPoRgkgATYTw5x5z8w@public.gmane.org
Subject: Re: [PATCH 3/4] powerpc/p1010: FlexCAN Controller for of_ type

On 08/08/2011 05:00 PM, Bhaskar Upadhaya wrote:

quoted

Provide FlexCAN support for Freescale P1010 SoC.
Modify the existing FlexCAN, so as to support the of_type approach on
P1010(power architecture based)SoC.

FlexCAN is a communication controller implementing the CAN protocol
according to the CAN 2.0B protocol specification.
This controller is available on Freescale P1010 platform.
Signed-off-by: Bhaskar Upadhaya <redacted>

NACK - your patch does more than the description states (debug code).

[Bhaskar] Ok I will change description as below
	This patch introduces the following features
	1. provides the support for FlexCAN on P1010 SoC.
	2. Provides the common read/write interface for ARM and PowerPC based FlexCAN.
	3. Provides the clock interface for PowerPC based FlexCAN.
	Will it be OK ?

Sorry, too late. Please try the patches posted by Robin recently. We are
currently reviewing those for mainline inclusion and would be happy, if
you would help.

Thanks,

Wolfgang.