Re: [PATCH 12/12] headers, ppp: Add missing #include to <linux/if_ppp.h>
From: David Miller <davem@davemloft.net>
Date: 2011-08-09 07:27:38
From: David Miller <davem@davemloft.net>
Date: 2011-08-09 07:27:38
From: Ben Hutchings <redacted> Date: Mon, 08 Aug 2011 14:25:19 +0100
<linux/if_ppp.h> uses various types defined in <linux/ppp_defs.h>. Signed-off-by: Ben Hutchings <redacted>
Unfortunately there is a "net/if_ppp.h" provided by glibc that includes "net/ppp_defs.h", and all of this is presumably in order to discourage direct use of the kernel headers. Even though net/ppp_defs.h ends up including linux/ppp_defs.h anyways. Whilst I think your efforts are to be commended, we can't start doing or else we'll start breaking the build in various unexpected ways. The SIOCDEVPRIVATE (defined by GLIBC in bits/ioctls.h) case is just one such example.