Re: [RFC PATCH v2 0/9] bql: Byte Queue Limits

On Mon, Aug 8, 2011 at 10:55 AM, Stephen Hemminger
[off-list ref] wrote:

On Mon, 8 Aug 2011 10:51:06 -0700
Tom Herbert [off-list ref] wrote:

quoted

On Mon, Aug 8, 2011 at 8:40 AM, Stephen Hemminger [off-list ref] wrote:

quoted

On Sun, 7 Aug 2011 21:43:13 -0700 (PDT)
Tom Herbert [off-list ref] wrote:

quoted

    netdev_tx_completed_queue: Called at end of transmit completion
      to inform stack of number of bytes and packets processed.
    netdev_tx_sent_queue: Called to inform stack when packets are
      queued.

Couldn't these be done for the device in the existing qdisc infra
structure (or dev_start_xmit). Alternatively, rename ndo_start_xmit
to something else and make all the callers use the wrapper.

Changing all the drivers for something that the driver has no real
need to care about seems like incorrect object design.

The netdev_tx_completed_queue is needed to inform the stack of number
of packets and bytes completed in an execution of transmit completion
(epic).  I don't see a way to get that information outside of the
driver.

Tom

Since transmit completion means calling dev_kfree_skb() why not account
there? You could add some info to netdev if necessary to get compile
the statistics.

I just hate driver api complexity growth.