RE: [PATCH ] cdc_ncm: fixes for big-endian architecture / MIPS
From: Alexey ORISHKO <hidden>
Date: 2011-08-03 14:07:18
From 8bd65735b4f0db5b6213f59a443c21d0d55dba8e Mon Sep 17 00:00:00 2001 From: Giuseppe Scrivano <redacted> Date: Fri, 15 Jul 2011 15:34:14 +0200 Subject: [PATCH] cdc_ncm: fix endianess problem. Signed-off-by: Giuseppe Scrivano <redacted> --- drivers/net/usb/cdc_ncm.c | 65 +++++++++++++++++++++++++------------------- -
quoted hunk
+struct cdc_ncm_request { + u8 bRequest; + u8 bmRequestType; + u16 wValue; + u16 wIndex; + u16 wLength; +} __packed;
Since it was incorrect to use struct usb_cdc_notification I would rather remove cdc_ncm_do_request() function and provide u16 parameters directly to usb_control_msg without creating yet additional structure for usb control request. alexey -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html