Re: [PATCH] net/fec: gasket needs to be enabled for some i.mx
From: Shawn Guo <hidden>
Date: 2011-07-22 02:00:31
Also in:
linux-arm-kernel
On Fri, Jul 08, 2011 at 08:06:39AM +0800, Shawn Guo wrote:
On Thu, Jul 07, 2011 at 12:44:09PM -0600, Grant Likely wrote:quoted
On Thu, Jul 07, 2011 at 09:41:58PM +0800, Shawn Guo wrote:quoted
On Thu, Jul 07, 2011 at 04:12:57AM -0700, David Miller wrote:quoted
From: Shawn Guo <redacted> Date: Fri, 1 Jul 2011 18:11:22 +0800quoted
On the recent i.mx (mx25/50/53), there is a gasket inside fec controller which needs to be enabled no matter phy works in MII or RMII mode. The current code enables the gasket only when phy interface is RMII. It's broken when the driver works with a MII phy. The patch uses platform_device_id to distinguish the SoCs that have the gasket and enables it on these SoCs for both MII and RMII mode. Signed-off-by: Troy Kisky <redacted> Signed-off-by: Shawn Guo <redacted>Acked-by: David S. Miller <davem@davemloft.net> --Thanks, David. I will try to get it through Sascha's tree after the rebase again dt series. Hi Sascha, How should we proceed? It seems Grant will take the fec-dt series on his tree. Would you then merge that tree into yours, so that I can rebase this patch on your tree and get it go through there?I should probably just take the lot.Thanks, Grant. That makes people's life easier. Please let me know once you apply the dt series, so that I can start rebase the patch on your tree.
I think I should repost the patch together with the device tree support one when Grant's devicetree/next and i.mx tree get merged on mainline in the coming merge window, and get them through Sascha's tree, so that we can avoid conflicts there. -- Regards, Shawn