Thread (11 messages) flat view 11 messages, 7 authors, 2011-07-23

Re: [PATCH] net: allow netif_carrier to be called safely from IRQ

From: David Miller <davem@davemloft.net>
Date: 2011-07-23 00:17:59
Also in: lkml

From: Stephen Hemminger <redacted>
Date: Fri, 22 Jul 2011 15:53:56 -0700
As reported by Ben Greer and Froncois Romieu. The code path in 
the netif_carrier code leads it to try and disable
a late workqueue to reenable it immediately
netif_carrier_on
-> linkwatch_fire_event
   -> linkwatch_schedule_work
      -> cancel_delayed_work
         -> del_timer_sync  

If __cancel_delayed_work is used instead then there is no
problem of waiting for running linkwatch_event.

There is a race between linkwatch_event running re-scheduling
but it is harmless to schedule an extra scan of the linkwatch queue.

Signed-off-by: Stephen Hemminger <redacted>
Applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help