Thread (4 messages) flat view 4 messages, 3 authors, 2011-07-13

Re: [PATCH] net: change return values in mac_pton() function

From: Arend van Spriel <hidden>
Date: 2011-07-13 11:22:30
Also in: lkml

On 07/13/2011 01:12 PM, David Miller wrote:
From: Alexey Dobriyan<redacted>
Date: Wed, 13 Jul 2011 13:09:03 +0300
quoted
On Wed, Jul 13, 2011 at 12:30 PM, Arend van Spriel[off-list ref]  wrote:
quoted
The original commit adding this function noted a diverge from usual
0=success/-E=fail, but no motivation for it.
I thought it was obvious, but indeed wasn't explicitely
mentioned in changelog. But see inet_pton(3).
Agreed it's better for mac_pton() to be consistent with existing,
similar, interfaces like inet_pton.
I just liked the general approach of zero indicating success. But even 
in the realm called Linux not everything can be black and white, I guess :-D

Please drop the patch.

Gr. AvS

-- 
Almost nobody dances sober, unless they happen to be insane.
-- H.P. Lovecraft --

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help