Thread (2 messages) flat view 2 messages, 2 authors, 2011-07-04

[rfc] Remove member .name from struct netpoll

From: Joe Perches <joe@perches.com>
Date: 2011-07-01 17:07:54
Also in: lkml

struct netpoll has member .name

struct netpoll {
	struct net_device *dev;
	char dev_name[IFNAMSIZ];
	const char *name;
[...]
};

that is set only by netconsole.c

static struct netconsole_target *alloc_param_target(char *target_config)
{
[...]
	nt->np.name = "netconsole";

and used only by net/core/netpoll.c to emit "netconsole: " on
logging messages.

e.g.

void netpoll_print_options(struct netpoll *np)
{
	printk(KERN_INFO "%s: local port %d\n",
			 np->name, np->local_port);

I think it'd be more common to use pr_fmt and pr_<level>
to emit these logging messages.

Are there out of tree users or plans to use "struct netpoll"
by other modules?

If not, I propose to remove name from the struct.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help