Wed, Jul 20, 2011 at 06:01:09PM CEST, mirqus@gmail.com wrote:

W dniu 20 lipca 2011 17:45 użytkownik Michał Mirosław
[off-list ref] napisał:

quoted

2011/7/20 Jiri Pirko [off-list ref]:

quoted

- unify vlan and nonvlan rx path
- kill nesvnic->vlan_grp and nes_netdev_vlan_rx_register
- allow to turn on/off rx/tx vlan accel via ethtool (set_features)

[...]

quoted

 /**

@@ -1656,7 +1679,7 @@ struct net_device *nes_netdev_init(struct nes_device *nesdev,

       netdev->ethtool_ops = &nes_ethtool_ops;
       netif_napi_add(netdev, &nesvnic->napi, nes_netdev_poll, 128);
       nes_debug(NES_DBG_INIT, "Enabling VLAN Insert/Delete.\n");
-       netdev->features |= NETIF_F_HW_VLAN_TX | NETIF_F_HW_VLAN_RX;
+       netdev->features |= NETIF_F_HW_VLAN_TX;

Just remove this line - nes_fix_features() is controlling the flag anyway.

Forget it - it's good.

I need to think about calling ndo_set_features callback at end of
register_netdev() so the drivers won't need to duplicate the
call/configuration in their ndo_init.

Yep, this came up to my thinking as well.

Best Regards,
Michał Mirosław