Re: [PATCH v2 04/46] net/wireless: p54: remove useless dma_sync_single_for_device(DMA_FROM_DEVICE)
From: Pavel Roskin <hidden>
Date: 2011-07-11 15:15:20
Also in:
linux-wireless
On 07/10/2011 08:52 PM, Michał Mirosław wrote:
Also constify pointers used in frame parsers to verify assumptions.
Cleanups are better done separately.
- u16 type = le16_to_cpu(*((__le16 *)skb->data)); + u16 type = le16_to_cpu(*(const __le16 *)skb->data);
I think it would be more appropriate to use get_unaligned_le16() here. No casts should be needed then. That's not an objection, just a suggestion :) -- Regards, Pavel Roskin -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html