[patch] packet: add an unlock on error in fanout_add()
From: Dan Carpenter <hidden>
Date: 2011-07-08 07:29:28
Also in:
kernel-janitors
Subsystem:
networking [general], packet sockets, the rest · Maintainers:
"David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Willem de Bruijn, Linus Torvalds
We need to release the "fanout_mutex" here. Signed-off-by: Dan Carpenter <redacted>
diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c
index aec50a1..3cbe950 100644
--- a/net/packet/af_packet.c
+++ b/net/packet/af_packet.c@@ -589,8 +589,10 @@ static int fanout_add(struct sock *sk, u16 id, u16 type_flags) break; } } - if (match && match->defrag != defrag) - return -EINVAL; + if (match && match->defrag != defrag) { + err = -EINVAL; + goto out_unlock; + } if (!match) { match = kzalloc(sizeof(*match), GFP_KERNEL); if (match) {
@@ -626,6 +628,8 @@ static int fanout_add(struct sock *sk, u16 id, u16 type_flags) } } } + +out_unlock: mutex_unlock(&fanout_mutex); return err; }