On Tue, 2011-06-28 at 21:36 +0100, Ben Hutchings wrote:

On Tue, 2011-06-28 at 13:31 -0700, Joe Perches wrote:

quoted

On Tue, 2011-06-28 at 21:21 +0100, Ben Hutchings wrote:

quoted

On Tue, 2011-06-28 at 12:40 -0700, Joe Perches wrote:

quoted

Use pr_fmt, pr_<level>, and netdev_<level> as appropriate.
Coalesce long formats.

[...]

quoted

--- a/net/core/dev.c

[]

quoted

quoted

quoted

+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt

[...]
KBUILD_MODNAME is presumably going to be "dev".

'tis.

quoted

That's not very meaningful.

Anything else you think it should be?
Maybe "net_core_device:" or some such like that?

"netdev"

Maybe.  David?  Got an opinion?

quoted

Here are the format strings now prefaced by "dev:"

$ strings net/core/built-in.o |grep "^<.>dev:"
<6>dev: netif_stop_queue() cannot be called before register_netdev()
<4>dev: dev_remove_pack: %p not found
<3>dev: Loading kernel module for a network device with CAP_SYS_MODULE (deprecated)
<0>dev: %s: failed to move %s to init_net: %d
<3>dev: alloc_netdev: Unable to allocate device with zero queues
<3>dev: alloc_netdev: Unable to allocate device with zero RX queues
<3>dev: alloc_netdev: Unable to allocate device

Many of these refer to a specific device and should be formatted with
one of the netdev_* logging functions.

Not true.

These are in the alloc_netdev function where
netdev_<level> can not yet be successfully used.