Re: [PATCH v2] net/r8169: update the new parser for the new firmware

hayeswang [off-list ref] :

Francois Romieu :

[...]

quoted

The new firmware format should be the same. The old 
r8168d-1.fw firmware proved usable when prefixed with :

0000000: 0000 0000 3031 0000 0000 0000 0000 0000  ....01..........
0000010: 0000 0000 0000 0000 0000 0000 0000 0000  ................
0000020: 0000 0000 3000 0000 7501 0000 a000 0000  ....0...u.......

I realized after testing that netif_err could be abused with 
non-string fw_info.version. :o/

Excuse me. I don't understand what you want to express. Do you mean the
situation of the old paser with the new firmware for checking the firmware?

No. The code does a printk with a %s specifier on fw_info.version while there
is no evidence that fw_info.version is 0 terminated.

For the normal situation, the old paser would not use the new firmware.
And I put zero in front of the new firmware to prevent the old paser from
running it. That is all I do.

It is fine.

-- 
Ueimor