Thread (2 messages) flat view 2 messages, 2 authors, 2011-06-17

Re: [PATCH] macvtap: remove wrong sock_put() in macvtap_put_queue()

From: David Miller <davem@davemloft.net>
Date: 2011-06-17 02:58:36
Also in: lkml

From: Jason Wang <redacted>
Date: Mon, 13 Jun 2011 11:15:19 +0800
The calling of sock_put() should be delayed after synchronize_rcu(),
otherwise inconsist data may be seen during packets transmitting.

Signed-off-by: Jason Wang <redacted>
You're leaking sockets now.

This function has to release the socket twice if there is
a non-NULL vlan assigned to the queue.

Now you're only doing it once in that situation.

Which probably fixes your crash, but adds a socket leak.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help