Re: [PATCH 06/11] drivers/net: use printk_ratelimited() instead of printk_ratelimit()
From: Joe Perches <joe@perches.com>
Date: 2011-06-16 16:43:56
Also in:
lkml
On Thu, 2011-06-16 at 14:12 +0200, Manuel Zerpies wrote:
Since printk_ratelimit() shouldn't be used anymore (see comment in include/linux/printk.h), replace it with printk_ratelimited()
[]
quoted hunk
diff --git a/drivers/net/sc92031.c b/drivers/net/sc92031.c
[]
quoted hunk
@@ -536,8 +537,7 @@ static bool _sc92031_check_media(struct net_device *dev) netif_carrier_on(dev); - if (printk_ratelimit()) - printk(KERN_INFO "%s: link up, %sMbps, %s-duplex\n", + printk_ratelimited(KERN_INFO "%s: link up, %sMbps, %s-duplex\n",dev->name, speed_100 ? "100" : "10", duplex_full ? "full" : "half");
All these might be better using net_ratelimit and netdev_<level> if (net_ratelimit()) netdev_info(dev, "link up, %uMbps, %s-duplex\n", speed_100 ? 100 : 10, duplex_full ? "full" : "half");
quoted hunk
@@ -549,8 +549,7 @@ static bool _sc92031_check_media(struct net_device *dev) _sc92031_disable_tx_rx(dev); - if (printk_ratelimit()) - printk(KERN_INFO "%s: link down\n", dev->name); + printk_ratelimited(KERN_INFO "%s: link down\n", dev->name);
etc... netdev_<level>_ratelimited (and netdev_<level>_once) could instead be added and used I suppose.