Thread (3 messages) read the whole thread 3 messages, 3 authors, 2011-06-13

Re: [PATCH] ieee802154: Don't leak memory in ieee802154_nl_fill_phy

From: David Miller <hidden>
Date: 2011-06-13 22:06:51
Also in: lkml

From: Dmitry Eremin-Solenikov <redacted>
Date: Tue, 14 Jun 2011 00:02:38 +0400
On 6/12/11, Jesper Juhl [off-list ref] wrote:
quoted
In net/ieee802154/nl-phy.c::ieee802154_nl_fill_phy() I see two small
issues.
1) If the allocation of 'buf' fails we may just as well return -EMSGSIZE
   directly rather than jumping to 'out:' and do a pointless kfree(0).
2) We do not free 'buf' unless we jump to one of the error labels and this
   leaks memory.
This patch should address both.

Signed-off-by: Jesper Juhl <redacted>
Acked-by: Dmitry Eremin-Solenikov <redacted>

David, please commit this.
Applied, thanks.

------------------------------------------------------------------------------
EditLive Enterprise is the world's most technically advanced content
authoring tool. Experience the power of Track Changes, Inline Image
Editing and ensure content is compliant with Accessibility Checking.
http://p.sf.net/sfu/ephox-dev2dev
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help