Re: [PATCH] bonding: use new value of lacp_rate and ad_select

On 06/09/2011 11:15 AM, Américo Wang wrote:

On Thu, Jun 9, 2011 at 11:13 AM, Américo Wang[off-list ref]  wrote:

quoted

On Thu, Jun 9, 2011 at 11:05 AM, WeipingPan[off-list ref]  wrote:

quoted

On 06/07/2011 10:24 AM, Weiping Pan wrote:

quoted

There is bug that when you modify lacp_rate via sysfs,
802.3ad won't use the new value of lacp_rate to transmit packets.
This is because port->actor_oper_port_state isn't changed.

As for ad_select, it can work,
but both struct bond_params and ad_bond_info have lacp_fast and ad_select,
they are duplicate and need extra synchronization.
802.3ad can get them from bond_params directly every time.

Any comments ?

I think you'd better separate bug fix from cleanup's.

By the way, please mark the version of your patch in $subject,
in this case, V3. And describe what you changed from V2.

ok, I will split the patch.

thanks
Weiping Pan