Re: [PATCH 4/5] ixgbe: Fix incorrect declaration of ixgbevf_mbx_ops

On Tue, Jun 7, 2011 at 15:56, Rose, Gregory V [off-list ref] wrote:

quoted

-----Original Message-----
From: Andi Kleen [mailto:andi@firstfloor.org]
Sent: Tuesday, June 07, 2011 3:27 PM
To: linux-kernel@vger.kernel.org
Cc: Andi Kleen; Kirsher, Jeffrey T; Brandeburg, Jesse; Rose, Gregory V
Subject: [PATCH 4/5] ixgbe: Fix incorrect declaration of ixgbevf_mbx_ops

From: Andi Kleen <redacted>

The header extern type of ixgbevf_mbx_ops disagreed with
the actual declaration. Fix this here.

This is rather scary. I haven't tested it. Did this
ever work?

Cc: jeffrey.t.kirsher@intel.com
Cc: jesse.brandeburg@intel.com
Cc: gregory.v.rose@intel.com
Signed-off-by: Andi Kleen <redacted>
---
 drivers/net/ixgbevf/ixgbevf.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ixgbevf/ixgbevf.h b/drivers/net/ixgbevf/ixgbevf.h
index b703f60..a2bbbb3 100644
--- a/drivers/net/ixgbevf/ixgbevf.h
+++ b/drivers/net/ixgbevf/ixgbevf.h

@@ -279,7 +279,7 @@ enum ixgbevf_boards {

 extern struct ixgbevf_info ixgbevf_82599_vf_info;
 extern struct ixgbevf_info ixgbevf_X540_vf_info;
-extern struct ixgbe_mac_operations ixgbevf_mbx_ops;
+extern struct ixgbe_mbx_operations ixgbevf_mbx_ops;

 /* needed by ethtool.c */
 extern char ixgbevf_driver_name[];
--
1.7.4.4

[Greg Rose]
Huh.

Well, mbx ops is a table of 8 pointers and mac ops is a table of 11 pointers, so the copy would have over written 3 * pointer-size words of some other memory.  But the 8 ops copied would have been correct so to the extent that we called them they worked.

Now that I look at it you missed a another spot where the copy is done that uses the ixgbe_mac_operations instead of the ixgbe_mbx_operations.

I'll fix that up.

Nice catch!

- Greg
--

I have an updated patch by Greg in my queue, which I will be
submitting through David Miller's networking tree.  Thanks Andi and
Greg!

-- 
Cheers,
Jeff