Re: [PATCH] net/can: activate bit-timing calculation and netlink based drivers by default
From: Marc Kleine-Budde <hidden>
Date: 2011-06-27 14:49:03
On 06/27/2011 03:50 PM, Kurt Van Dijck wrote:
Is this modification then also the right thing to do?
yes - there's no need for "default N' (or 'default n') as it's default.
quoted hunk
diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig index 1d699e3..ac48574 100644 --- a/drivers/net/can/Kconfig +++ b/drivers/net/can/Kconfig@@ -4,7 +4,6 @@ menu "CAN Device Drivers" config CAN_VCAN tristate "Virtual Local CAN Interface (vcan)" depends on CAN - default N ---help--- Similar to the network loopback devices, vcan offers a virtual local CAN interface.@@ -15,7 +14,6 @@ config CAN_VCAN config CAN_SLCAN tristate "Serial / USB serial CAN Adaptors (slcan)" depends on CAN - default N ---help--- CAN driver for several 'low cost' CAN interfaces that are attached via serial lines or via USB-to-serial adapters using the LAWICEL@@ -124,7 +122,6 @@ source "drivers/net/can/softing/Kconfig" config CAN_DEBUG_DEVICES bool "CAN devices debugging messages" depends on CAN - default N ---help--- Say Y here if you want the CAN device drivers to produce a bunch of debug messages to the system log. Select this if you are having
If you make a patch from it... Acked-by: Marc Kleine-Budde <redacted> Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |