Thread (15 messages) 15 messages, 3 authors, 2011-06-24

Re: [net-next 02/11] ixgbe: fix flags relating to perfect filters to support coexistence

flat view

From: Joe Perches <joe@perches.com>
Date: 2011-06-24 06:40:43

On Thu, 2011-06-23 at 23:03 -0700, Jeff Kirsher wrote:
quoted hunk ↗ jump to hunk
From: Alexander Duyck <redacted>
diff --git a/drivers/net/ixgbe/ixgbe_dcb_nl.c b/drivers/net/ixgbe/ixgbe_dcb_nl.c
[]
quoted hunk ↗ jump to hunk
@@ -114,11 +114,12 @@ static u8 ixgbe_dcbnl_set_state(struct net_device *netdev, u8 state)
 	u8 err = 0;
 	struct ixgbe_adapter *adapter = netdev_priv(netdev);
 
+	/* verify there is something to do, if not then exit */
+	if (!!state != !(adapter->flags & IXGBE_FLAG_DCB_ENABLED))
+		return err;
That's a bit hard to read.  Maybe this is clearer?

	if (!!state == !!(adapter->flags & IXGBE_FLAG_DCG_ENABLED))

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help