Re: [net-2.6 PATCH 2/3] qlge:Fix printk priority so chip fatal errors are always reported.
From: Joe Perches <joe@perches.com>
Date: 2011-06-23 18:50:51
On Thu, 2011-06-23 at 10:52 -0700, Ron Mercer wrote:
From: Jitendra Kalsaria <redacted> Precedence of the printk should be at higher level so chip fatal errors are always reported.
You probably want to use netdev_err then, not a masked netif_err when it is optionally not reported.
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
[]
quoted hunk ↗ jump to hunk
@@ -2170,7 +2170,7 @@ static void ql_process_chip_ae_intr(struct ql_adapter *qdev, return; case CAM_LOOKUP_ERR_EVENT: - netif_err(qdev, link, qdev->ndev, + netif_err(qdev, drv, qdev->ndev, "Multiple CAM hits lookup occurred.\n");
netdev_err(qdev->ndev, "Multiple CAM hits lookup occurred\n");
quoted hunk ↗ jump to hunk
@@ -2178,13 +2178,13 @@ static void ql_process_chip_ae_intr(struct ql_adapter *qdev, return; case SOFT_ECC_ERROR_EVENT: - netif_err(qdev, rx_err, qdev->ndev, + netif_err(qdev, drv, qdev->ndev, "Soft ECC error detected.\n");
netdev_err(qdev->ndev, "Soft ECC error detected\n"); etc...