Re: [PATCH V3 10/11] mv643xx_eth: enable transmit time stamping.
From: Lennert Buytenhek <hidden>
Date: 2011-06-20 16:35:26
On Mon, Jun 20, 2011 at 09:51:32AM +0200, Richard Cochran wrote:
quoted hunk ↗ jump to hunk
This patch enables software (and phy device) transmit time stamping. Compile tested only. Cc: Lennert Buytenhek <redacted> Signed-off-by: Richard Cochran <redacted> --- drivers/net/mv643xx_eth.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c index 1b7d2c1..3671714 100644 --- a/drivers/net/mv643xx_eth.c +++ b/drivers/net/mv643xx_eth.c@@ -847,6 +847,8 @@ no_csum: /* clear TX_END status */ mp->work_tx_end &= ~(1 << txq->index); + skb_tx_timestamp(skb); + /* ensure all descriptors are written before poking hardware */ wmb(); txq_enable(txq);
This only timestamps the skb _after_ writing the final (cmd_sts) HW TX descriptor word, and so if your previous patch is correct (which I don't think it is), this would be buggy as well.