Re: [PATCH 10/14] SIWv2: Transmit path: siw_qp_tx.c

On Mon, Jun 20, 2011 at 2:33 PM, Bernard Metzler [off-list ref] wrote:

bart.vanassche-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote on 06/18/2011 07:47:29 PM:

quoted

On Thu, Jun 16, 2011 at 2:42 PM, Bernard Metzler [off-list ref]

wrote:

quoted

quoted

+               if (tx_type == RDMAP_RDMA_READ_REQ) {

This is what the compiler says about the above statement:

drivers/infiniband/hw/siw/siw_qp_tx.c:1145:15: warning: comparison
between enum siw_wr_opcode and enum rdma_opcode

So how can that statement be correct ?

it will not - must be changed to 'SIW_WR_RDMA_READ_REQ'...many thanks!
I obviously used sparse in a wrong way:
building within kernel tree with 'make C=1 CF="-Wsparse-all' does not give
me the indicated warning (neither does setting CF="-Wenum-mismatch").

That warning was not reported by sparse but by gcc 4.5.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html