Re: [RFC] Moving files around in drivers/net

[snip]

quoted

quoted

commit 83df87d655e25119eafaeb4225bc5eedaa82c6e0
Author: Jeff Kirsher [off-list ref]
Date:   Fri May 13 02:24:46 2011 -0700

   myri*: Move the Myricom drivers

   Move the Myricom drivers into drivers/net/ethernet/myricom/ and

make

quoted

   the necessary Kconfig and Makefile changes.

   CC: Andrew Gallatin [off-list ref]
   CC: Brice Goglin [off-list ref]
   Signed-off-by: Jeff Kirsher [off-list ref]

 MAINTAINERS                                        |    2 +-
 drivers/net/Kconfig                                |   35

-------------

quoted

 drivers/net/Makefile                               |    3 -
 drivers/net/ethernet/Kconfig                       |    1 +
 drivers/net/ethernet/Makefile                      |    1 +
 drivers/net/ethernet/myricom/Kconfig               |   51

++++++++++++++++++++

quoted

 drivers/net/ethernet/myricom/Makefile              |    6 ++
 .../net/{ => ethernet/myricom}/myri10ge/Makefile   |    0
 .../net/{ => ethernet/myricom}/myri10ge/myri10ge.c |    0
 .../{ => ethernet/myricom}/myri10ge/myri10ge_mcp.h |    0
 .../myricom}/myri10ge/myri10ge_mcp_gen_header.h    |    0
 drivers/net/{ => ethernet/myricom}/myri_sbus.c     |    0
 drivers/net/{ => ethernet/myricom}/myri_sbus.h     |    0

/me puts on Myricom hat

I believe we want to put the driver above in the sbus/legacy
directory.  Better yet, move this driver to /dev/null.  There is no
possibility of ethernet mode on this adapter, so it's Myrinet only.
It won't inter-op with modern versions of Myrinet, and thus can only
work with legacy adapters.  There are no drivers for the PCI version
of this adapter, so it only can work on ~15year old hardware.  It's
long in the tooth, let's take it to the knackers.

Thanks,
Jon

That sounds good.  Since I am not the maintainer or author of the
driver, I think such a move should come from Myricom.  I can drop the
move of myri_sbus.[ch] from my patches to organize the driver/net/
directory.

I'll submit a patch shortly to remove it.  Assuming that it will be
rejected, I'd recommend putting myri_sbus.* into
 drivers/net/myrinet/
similar to how you have an ethernet directory.

Thanks,
Jon