Re: [PATCH 1/2] sctp: HEARTBEAT negotiation after ASCONF
From: David Miller <davem@davemloft.net>
Date: 2011-06-19 23:10:42
From: Michio Honda <redacted> Date: Thu, 16 Jun 2011 17:56:42 +0900
quoted hunk ↗ jump to hunk
@@ -989,6 +991,8 @@ static int sctp_outq_flush(struct sctp_outq *q, int rtx_timeout) ((new_transport->state == SCTP_INACTIVE) || (new_transport->state == SCTP_UNCONFIRMED))) new_transport = asoc->peer.active_path; + if (new_transport->state == SCTP_UNCONFIRMED) + continue; /* Change packets if necessary. */ if (new_transport != transport) {
This code path uses the asoc->peer.active_path is the new_transport is in the SCTP_UNCONFIRMED state. Are you sure your new check is correct in that case? Shouldn't you be testing the variable "new_transport" instead?