Thread (1 message) 1 message, 1 author, 2011-06-15

Re: [PATCH 1/2] batman-adv: count_real_packets() in batman-adv assumes char is signed

From: Sven Eckelmann <hidden>
Date: 2011-06-15 05:59:15
Also in: batman

David Howells wrote:
count_real_packets() in batman-adv assumes char is signed, and returns -1
through it:

net/batman-adv/routing.c: In function 'receive_bat_packet':
net/batman-adv/routing.c:739: warning: comparison is always false due to
limited range of data type

Use int instead.
[...]
-static char count_real_packets(struct ethhdr *ethhdr,
-			       struct batman_packet *batman_packet,
-			       struct hard_iface *if_incoming)
+static int count_real_packets(struct ethhdr *ethhdr,
+			      struct batman_packet *batman_packet,
+			      struct hard_iface *if_incoming)
 {

This one doesn't apply on linux-next/net-next-2.6, but I will fix it by hand.

Thanks,
	Sven

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help