Re: [E1000-devel] [PATCH] e100: Fix inconsistency in bad frames handling

On Tue, 2011-06-14 at 10:30 -0700, Ben Greear wrote:

quoted

quoted

How would a received skb be flagged as having a CRC error?

maybe some skb->pkt_type = PACKET_INVALID; or something...

Jesse:  If I can get the ethtool related patches accepted, would
you accept patches to e100 (and other Intel drivers) for
this feature?

seems like a reasonable thing, but, there is some risk that might
prevent us turning this on however, because we often like our hardware
to discard bad frames because (especially) long ones can use quite a few
buffers.

I still am generally uncomfortable with this idea.  We've survived a
long time without it and it opens up the possibility of extra bugs (like
possible security issues, etc) with very little opportunity for
worthwhile gain.

Jesse