Thread (16 messages) flat view 16 messages, 3 authors, 2011-06-12

Re: [PATCH 01/10] net: introduce time stamping wrapper for netif_rx.

From: Richard Cochran <richardcochran@gmail.com>
Date: 2011-06-12 12:04:11

On Sat, Jun 11, 2011 at 04:10:25PM -0700, David Miller wrote:
Also, it makes no sense to add this for obsolete RX processing such
that netif_rx() is.

If drivers want to add fancy features like this timestamping stuff,
they better move on to NAPI, GRO, etc. first.  Putting support for
new features into deprecating things like netif_rx() makes no
sense at all.
Okay, I see your point. I won't bother trying to improve the "academy
of ancient drivers," and I'll repost without the netif_rx wrapper.

However, I do want to support the coldfire fec driver, since Freescale
is selling two coldfire development boards with the dp83640 phy. But I
don't think it makes sense to try and upgrade the fec driver to napi,
when a simple "if !skb_defer_rx_timestamp" will do there.

Thanks,
Richard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help