Thread (21 messages) 21 messages, 2 authors, 2011-06-09

Re: [net-next 00/12][pull request] Intel Wired LAN Driver Update

flat view

From: Jeff Kirsher <hidden>
Date: 2011-06-09 07:53:31

On Thu, 2011-06-09 at 00:50 -0700, David Miller wrote:
From: Jeff Kirsher <redacted>
Date: Thu, 09 Jun 2011 00:46:50 -0700
quoted
quoted
Actually, I have to un-pull.  Please build test your changes:

drivers/infiniband/core/netlink.c: In function ‘ibnl_rcv_msg’:
drivers/infiniband/core/netlink.c:151:9: error: too few arguments to function ‘netlink_dump_start’
include/linux/netlink.h:260:12: note: declared here
make[3]: *** [drivers/infiniband/core/netlink.o] Error 1
make[2]: *** [drivers/infiniband/core] Error 2
make[1]: *** [drivers/infiniband] Error 2
make[1]: *** Waiting for unfinished jobs....
I built tested after every patch and did not have any issues.  I see
Greg made some changes to include/linux/netlink.h which may be the
result of this error.
Well of course, the arguments to netlink_dump_start() changed and therefore
every call site needs to be updated.

Unless you don't have infiniband enabled in your builds, you should be
hitting this build failure too.
Just did, I saw that I did not have enabled and I got the same issue.  I
am looking into now, and will check to make sure there were no other
netlink_dump_start() references missed as well.

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help