Re: [net-next 38/40] ixgbe: Update feature flags so that LRO and Ntuple are restricted

On 06/07/2011 06:15 AM, Ben Hutchings wrote:

On Tue, 2011-06-07 at 05:33 -0700, Jeff Kirsher wrote:

quoted

From: Alexander Duyck<redacted>

This change makes it so that LRO and Ntuple flags are correctly restricted
to only devices that support those features.  Currently we weren't
enforcing any of those restrictions and as such it was possible to do
things such as enable LRO without it actually being supported on the
hardware.

This change also makes a slight modification to the code that assumes the
ETH_FLAG_RXVLAN is the same as the netdev flag. I corrected it by just adding
a !! to cast the result of the flag&  to a bool in order to guarantee the two
checks are compared as boolean values.

[...]

You could BUILD_BUG_ON(ETH_FLAG_RXVLAN != NETIF_F_HW_VLAN_RX).

Or implement the new features interface like every other driver...

Ben.

I hadn't looked at what was going on outside of the Intel drivers and 
didn't realize that the get/set_flags calls had been deprecated.

For now I would appreciate it if the existing patch does get accepted, 
but I will see what can be done to move things over to using the new 
features interface.

Thanks,

Alex