Thread (29 messages) 29 messages, 7 authors, 2011-06-09

Re: [PATCHv3] net: Define enum for the bits used in features.

From: David Miller <davem@davemloft.net>
Date: 2011-06-06 19:21:12

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Mon, 6 Jun 2011 18:32:53 +0300
On Sun, Jun 05, 2011 at 10:15:37PM -0700, David Miller wrote:
quoted
Since the GSO accessors deal with mutliple bits, you can create
special GSO specific interfaces to manipulate them.
Yes but it's not just GSO.
It's anything that includes more than 1 feature.
Examples:
NETIF_F_ALL_CSUM
NETIF_F_ALL_TX_OFFLOADS
NETIF_F_V6_CSUM
NETIF_F_SOFT_FEATURES

etc

Creating many accessors for each will need a lot
of code duplication ...
Yet this is something you must resolve in order to change the feature
bit implementation.

Whether this issue is difficult or not to address, it has to be done
either way.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help