Thread (33 messages) read the whole thread 33 messages, 7 authors, 2011-06-05

Re: [PATCH] bonding: reset queue mapping prior to transmission to physical device (v2)

From: Vitalii Demianets <hidden>
Date: 2011-06-03 14:59:49

On Friday 03 June 2011 16:26:47 Neil Horman wrote:
[...]
+	/*
+	 *restore the origional mapping
 Style and spelling nits, shouldn't it be:
* Restore the original mapping
+	 */
+	skb_set_queue_mapping(skb, (u16)skb->cb[0]);
As already pointed by Ben, it should be ((u16 *)skb->cb)[0]
[...]
+	/*
+ 	 * Save the origional txq to restore before passing to the driver
Spelling: original
+ 	 */
+	skb->cb[0] = txq;
As already pointed by Ben, it should be ((u16 *)skb->cb)[0]

-- 
Vitalii Demianets
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help