Thread (34 messages) 34 messages, 8 authors, 2011-07-13

Re: Kernel crash after using new Intel NIC (igb)

From: Eric Dumazet <hidden>
Date: 2011-05-29 07:33:53
Also in: lkml

Le samedi 28 mai 2011 à 20:04 +0200, Ingo Molnar a écrit :
* Eric Dumazet [off-list ref] wrote:
quoted
quoted
+static inline int atomic_add_unless(atomic_t *v, int a, int u)
+{
+	return __atomic_add_unless(v, a, u) != u;
 }
 
 #define atomic_inc_not_zero(v) atomic_add_unless((v), 1, 0)
As I said, atomic_add_unless() has several implementations in 
various arches. You must take care of all, not only x86.
It's a bit sad to see local hacks to generic facilities committed 
upstream like that.
Again, its a stable candidate patch, on a file that had many changes in
recent kernels.

I felt this was the right thing to do, to ease stable teams work.

Its not like there is an urgent need for this atomic_add_unless_return()
thing that we have to worry right now.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help