[v2 063/115] sysctl: simplify find_in_table
From: Lucian Adrian Grijincu <hidden>
Date: 2011-05-08 22:52:10
Also in:
lkml
Subsystem:
filesystems (vfs and infrastructure), proc filesystem, proc sysctl, the rest · Maintainers:
Alexander Viro, Christian Brauner, Kees Cook, Joel Granados, Linus Torvalds
The if (!p->procname) check is useless because the loop condition prevents it from happening. Signed-off-by: Lucian Adrian Grijincu <redacted> --- fs/proc/proc_sysctl.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index f50133c..d1640bc 100644
--- a/fs/proc/proc_sysctl.c
+++ b/fs/proc/proc_sysctl.c@@ -52,18 +52,12 @@ static struct ctl_table *find_in_table(struct ctl_table *p, struct qstr *name) int len; for ( ; p->procname; p++) { - if (!p->procname) - continue; - len = strlen(p->procname); if (len != name->len) continue; - if (memcmp(p->procname, name->name, len) != 0) - continue; - - /* I have a match */ - return p; + if (memcmp(p->procname, name->name, len) == 0) + return p; } return NULL; }
--
1.7.5.134.g1c08b