Re: [PATCH 3/3] net: Kill ratelimit.h dependency in linux/net.h
From: Ingo Molnar <hidden>
Date: 2011-05-27 08:44:08
* David Miller [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Ingo Molnar noticed that we have this unnecessary ratelimit.h dependency in linux/net.h, which hid compilation problems from people doing builds only with CONFIG_NET enabled. Move this stuff out to a seperate net/net_ratelimit.h file and include that in the only two places where this thing is needed. Signed-off-by: David S. Miller <davem@davemloft.net> --- include/linux/net.h | 6 ------ net/core/sysctl_net_core.c | 1 + net/core/utils.c | 1 + 3 files changed, 2 insertions(+), 6 deletions(-)diff --git a/include/linux/net.h b/include/linux/net.h index 1da55e9..b299230 100644 --- a/include/linux/net.h +++ b/include/linux/net.h@@ -289,11 +289,5 @@ extern int kernel_sock_shutdown(struct socket *sock, MODULE_ALIAS("net-pf-" __stringify(pf) "-proto-" __stringify(proto) \ "-type-" __stringify(type)) -#ifdef CONFIG_SYSCTL -#include <linux/sysctl.h> -#include <linux/ratelimit.h> -extern struct ratelimit_state net_ratelimit_state; -#endif -
Assuming that this moved into net_ratelimit.h with a guard define this looks good to me: Acked-by: Ingo Molnar <redacted> Thanks, Ingo