Re: [BUG] netconsole broken by scheduler updates
From: David Miller <davem@davemloft.net>
Date: 2011-05-26 20:18:34
From: Peter Zijlstra <redacted> Date: Thu, 26 May 2011 11:48:28 +0200
Also, are you very _very_ sure that lockdep message is a false positive?
I suspect these warnings are entirely specific to using netconsole
with the forcedeth driver.
There is some really scary stuff in there, to say the least.
Just have a look at nv_do_nic_poll(). That's the first time I've
seen a networking driver use the {disable,enable}_irq_lockdep()
interfaces.
It's also using netif_tx_unlock_bh() in the "recovery" case which
in netpoll will cause a local_bh_enable() with cpu interrupts
disabled. Which is not allowed.
Much of the forcedeth driver's locking seems suspect to me.