Re: [PATCH] ethtool: ETHTOOL_SFEATURES: remove NETIF_F_COMPAT return
From: David Miller <davem@davemloft.net>
Date: 2011-05-24 19:39:36
From: David Miller <davem@davemloft.net>
Date: 2011-05-24 19:39:36
From: Michał Mirosław <mirq-linux@rere.qmqm.pl> Date: Tue, 24 May 2011 11:14:37 +0200
On Thu, May 19, 2011 at 12:03:31PM +0200, Michał Mirosław wrote:quoted
On Mon, May 16, 2011 at 02:09:58PM -0400, David Miller wrote:quoted
You guys really need to sort this out properly. Please resubmit whatever final solution is agreed upon.I noticed that v2.6.39 was tagged today. We should definitely remove NETIF_F_COMPAT so it won't bite us in the future. The other patch that fixes ethtool_ops->set_flags compatibility is a bugfix, so it should go in - if we decide that the SFEATURES compatibility should be removed it won't matter. Ben, do you agree?Ping? http://patchwork.ozlabs.org/patch/95552/ (this is a bugfix, so should go to stable) http://patchwork.ozlabs.org/patch/95753/ (removes ETHTOOL_F_COMPAT; this we need to decide on)
You and Ben are still arguing over details. I want fresh versions of these patches (yes, both of them) once all of the issues are resolved.