Thread (22 messages) 22 messages, 8 authors, 2011-06-18

Re: [RFC Patch] bonding: move to net/ directory

From: Américo Wang <hidden>
Date: 2011-05-24 14:00:24

On Mon, May 23, 2011 at 11:13 PM, Andy Gospodarek [off-list ref] wrote:
On Mon, May 23, 2011 at 08:45:14PM +0800, Américo Wang wrote:
quoted
Hello, Jay, Andy,

Is there any peculiar reason that bonding code has to stay
in drivers/net/ directory?

Since bonding and bridge are somewhat similar, both of
which are used to "bond" two or more devices into one,
and bridge code is already in net/bridge/, so I think it also
makes sense to move bonding code into net/bonding/ too.

This could also help to grep the source more easily. :)

What do you think about the patch below?
(Note, this patch is against net-next-2.6.)
I would rather keep the code for bonding in drivers/net since it is
really a pure device (though not directly tied to any specific
hardware) rather than a device + forwarding or management code.
Is this a reason strong enough to leave it to drivers/net/ ?
I think it is generic enough to be moved to net/ directory... :-/
It has bothered me for a long time that the code just to manage the VLAN
and bridge devices sits outside of drivers/net, but I've never proposed
a patch to move the files as I suspect the maintainers of that code
would like to keep it all together.  Maybe it is time to do that.
You mean move net/8021q/ to drivers/net/8021q/ ?

Thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help