Thread (13 messages) 13 messages, 3 authors, 2011-06-01

Re: [PATCHv4 net-next-2.6] ethtool: Added support for FW dump

From: David Miller <davem@davemloft.net>
Date: 2011-05-13 18:40:07

From: Ben Hutchings <redacted>
Date: Fri, 13 May 2011 00:05:07 +0100
On Thu, 2011-05-12 at 15:48 -0700, Anirban Chakraborty wrote:
quoted
Added code to take FW dump via ethtool. Dump level can be controlled via setting the
dump flag. A get function is provided to query the current setting of the dump flag.
Dump data is obtained from the driver via a separate get function.

Changes from v3:
Fixed buffer length issue in ethtool_get_dump_data function.
Updated kernel doc for ethtool_dump struct and get_dump_flag function.

Changes from v2:
Provided separate commands for get flag and data.
Check for minimum of the two buffer length obtained via ethtool and driver and
use that for dump buffer
Pass up the driver return error codes up to the caller.
Added kernel doc comments.

Signed-off-by: Anirban Chakraborty <redacted>
Reviewed-by: Ben Hutchings <redacted>

There is one tiny error I didn't notice before, which I think David can
fix up if and when he applies this:
Applied with "u8/__u8" fixed up, thanks!
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help