Re: [PATCH net-next] ethtool: bring back missing comma in netdev_features_strings

On 12/05/11 10:55, Michał Mirosław wrote:

2011/5/12 Franco Fichtner [off-list ref]:

quoted

I found this while skimming through recent net-next patches.
I'm not quite sure if the padding in this struct is correct now.

Nice catch. But please send the patch inline instead of as an attachment.

Thanks, but I have a short question. Are the empty strings in
this struct really needed?

        /* NETIF_F_TSO6 */            "tx-tcp6-segmentation",
        /* NETIF_F_FSO */             "tx-fcoe-segmentation",
        "",
        "",

        /* NETIF_F_FCOE_CRC */        "tx-checksum-fcoe-crc",

They seem to have caused this mess in the first place and I would
think they could be removed entirely.

I will resend the patch later today as inline. Sorry about that.


Franco