Re: [PATCH net-next] netdevice.h: Align struct netdevices members
From: Joe Perches <joe@perches.com>
Date: 2011-05-10 04:22:06
On Tue, 2011-05-10 at 05:53 +0200, Eric Dumazet wrote:
Le lundi 09 mai 2011 à 20:42 -0700, Joe Perches a écrit :quoted
Save a bit of space.Hmm... correct alignements are far more important for this structure.
I agree. I aligned these members on "natural" boundaries. 4 consecutive chars rather than 2 chars, unsigned long.
Did you run benchmarks on 32bit and 64bit platforms ?
Nope.
BTW we have ____cacheline_aligned_in_smp markers, I am not even sure this patch saves space.
That depends on whether or not CONFIG_SMP is defined and all of the changes are before any ____cacheline_aligned markers.