Re: [PATCH] net/bonding: bonding: Adjust coding style for bond_3ad files.

On Wed, 2011-05-04 at 16:38 -0700, Stephen Hemminger wrote:

On Wed, 4 May 2011 19:18:47 -0300
Rafael Azenha Aquini [off-list ref] wrote:

quoted

-// compare MAC addresses
 #define MAC_ADDRESS_COMPARE(A, B) memcmp(A, B, ETH_ALEN)
 static struct mac_addr null_mac_addr = { { 0, 0, 0, 0, 0, 0 } };

These should be changed to use compare_ether_addr and is_zero_ether_addr
routines in etherdevice.h

Hey Stephen.

null_mac_addr is used as a struct and should not be changed
to is_zero_ether_addr.
Maybe the uses could be changed to a memset, but I seem to
recall the code gets bigger.

drivers/net/bonding/bond_3ad.c:1637:		aggregator->partner_system = null_mac_addr;
drivers/net/bonding/bond_3ad.c:1660:		aggregator->aggregator_mac_address = null_mac_addr;
drivers/net/bonding/bond_3ad.c:1696:		port->actor_system = null_mac_addr;